Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-twisted-core - An asynchronous networking framework written in Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208169 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-11-03 08:47 EST ------- A few more quick comments before I do a more detailed review (hopefully later today): 1. I think the Group for the -doc subpackage should be Documentation 2. I think the Group for the -zsh subpackage should be System Environment/Shells (à la bash-completion in Extras) 3. Is %{python_sitearch}/twisted/python/_twisted_zsh_stub needed, or can it be removed since we have %{_datadir}/zsh/site-functions/_twisted_zsh_stub? 4. The docs in the -zsh subpackage are duplicates of the same docs in the main package. How about as an alternative: %prep ... # Generate a brief README.zsh awk '/^Zsh Notes:/,/^Have fun!/' twisted/python/zshcomp.py > README.zsh %files zsh ... %doc README.zsh 5. TwistedCore contains an extensive test suite. After installing the package, I can run it OK using "trial twisted", but it seems to fail some tests when I try to run it in the buildroot in %check; any thoughts on what to do about testing? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review