[Bug 606714] Review Request: eekboard - A Virtual Keyboard for GNOME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606714

Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka@xxxxxxxxxxxxxxxxxxx

--- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-26 05:14:42 EDT ---
Some notes:

* BuildRoot
  - BuildRoot tag is no longer used (even if rpmlint may complain if you
    remove this)
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

  ! By the way for this package %clean is also unneeded because this
    package won't build on F-12 (c.f.:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2273814 :
    higher gtk seems needed )
    and %clean is not needed for F-13+:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

* BR
  - Please try to remove redundant BRs
    - "glib2-devel" is always required by "gtk2-devel"
    - You probably need gobject-introspection"-devel" (not just
gobject-introspection)
      ! Note that gobject-introspection-devel is required by clutter-devel
        (and so clutter-gtk-devel)

* build issues
  - The spec file contains:
-----------------------------------------------------
    62  # Prevent the upstream configure script from using clutter-gtk-0.90,
    63  # which is not available in Fedora yet.
    64  export CLUTTER_GTK_CFLAGS=`pkg-config clutter-gtk-0.10 --cflags`
    65  export CLUTTER_GTK_LIBS=`pkg-config clutter-gtk-0.10 --libs`
-----------------------------------------------------
    Why is this needed while configure.ac contains the below?
-----------------------------------------------------
    72    PKG_CHECK_MODULES([CLUTTER_GTK], [clutter-gtk-0.90],
    73      [enable_clutter_gtk=yes])
    74    if test x$enable_clutter_gtk = xno; then
    75      PKG_CHECK_MODULES([CLUTTER_GTK], [clutter-gtk-0.10],
    76        [enable_clutter_gtk=yes])
    77    fi
-----------------------------------------------------
  - Your srpm fails to build on F-13 as:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2273819
    Note that current dist-f13-build pango is 1.28.0-1.fc13 and
    introspection is enabled from 1.28.0-2

* Desktop file verification
-----------------------------------------------------
   518 
/builddir/build/BUILDROOT/eekboard-0.0.3-2.fc14.i386/usr/share/applications/eekboard.desktop:
error: (will be fatal in the future): value "GNOME" in key "Categories" in
group "Desktop Entry" requires another category to be present among the
following categories: GTK
-----------------------------------------------------
  - Please consider to fix this.

* Documents
  - "AUTHORS COPYING README" should be moved to -libs, because
    eekboard depends on -libs and not the opposite.

* Directory ownership issue
  - Please take care of directory ownership issue
------------------------------------------------------
# rpm -qf /usr/include/eek-0.1/ /usr/include/eek-0.1/eek/ /usr/share/vala/
/usr/share/vala/vapi/
file /usr/include/eek-0.1 is not owned by any package
file /usr/include/eek-0.1/eek is not owned by any package
file /usr/share/vala is not owned by any package
file /usr/share/vala/vapi is not owned by any package
------------------------------------------------------

! Functionality
  - By the way (with using rawhide) when I try to
    * launch uxterm
    * launch eekboard from uxterm
    * choose 'ヘルプ' -> '情報', then choose '閉じる' on the popup'ed window
    Then eekboard freezes....

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]