Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606064 Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michael.silvanus@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |michael.silvanus@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-06-25 07:23:09 EDT --- Everything looks in good shape. APPROVED * DONE Review [100%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** DONE source files match upstream sha1sum: f11f7aff4f59c669a07a5f3481cb69505270b008 ** DONE License [3/3] *** DONE License is Fedora-approved *** DONE License field accurate all C++ source files have the "later version" provision *** DONE License included iff packaged by upstream ** DONE rpmlint [2/2] *** DONE on src.rpm libfc14audiodecoder.src: E: unknown-key GPG#b8af1c54 -> private signing key, ignoring "error" libfc14audiodecoder.src: W: no-buildroot-tag -> fine for F-13+ *** DONE on x86_64.rpm Spurious warnings from rpmlint spellcheck; can be ignored ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** N/A Use %find_lang to handle locale files ** DONE Build [3/3] *** DONE Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=2271926 *** DONE BRs complete *** DONE Directory ownership ** DONE Spec inspection [8/8] *** DONE ldconfig for libraries *** DONE No duplicate files *** DONE File permissions *** DONE Filenames must be UTF-8 *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install 2*** DONE Macro usage consistent *** DONE Documentation [2/2] **** N/A If large docs, separate -doc **** DONE %doc files are non-essential *** DONE Development [5/5] **** DONE Headers in -devel **** DONE If versioned .so's, unversioned in -devel **** N/A Static only if necessary, put in -static **** DONE -devel, -static requires main **** DONE No .la -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review