Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607777 --- Comment #4 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-06-25 07:05:12 EDT --- (In reply to comment #3) > > %{_datadir}/vala/vapi/xnoise-1.0.* > > Nothing pulls in vala when installing xnoise-devel, but vala is the package > that owns the vala/vapi directories. You either need to include these > directories with the same permissions as in "vala" or require "vala": > https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership > Thanks. I initially Req:ed vala, then thought that was unnecessary but forgot to own the directory as well. > * rpmlint: > > xnoise.x86_64: E: incorrect-locale-subdir > /usr/share/locale/default/LC_MESSAGES/xnoise.mo > > Indeed looks like a file you ought to delete or %exclude. Probably cleaner to delete it, and before %find_lang is run; not sure how %exclude interacts with the file listing generated by %find_lang > > > * Should xnoise play _all_ files understood by GStreamer? For example, with > gstreamer-plugins-ugly installed, it plays .sid files (MIME type > audio/prs.sid). But with gstreamer-plugins-fc installed, it doesn't recognize > .fc files (which are played by rhythmbox, on the contrary). Sounds like a bug that should be filed upstream. > * Translations are far from complete. The de_DE translation module is mostly > useless. In this case, should it be excluded, or should I ship it anyway? (will keep it in the current revision, but please let me know if it's better to exclude such files) > > > * Other than that, the packaging is fine, and the app works. Thanks. Updated SRPM here: http://salimma.fedorapeople.org/specs/gnome/xnoise-0.1.6-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review