Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603295 --- Comment #6 from huwang <huwang@xxxxxxxxxx> 2010-06-18 09:34:26 EDT --- (In reply to comment #5) > Unfortunately that symlink in /usr/share/java is still wrong. This whole part: > install -Dpm 644 build/dist/guava-r%{version}/%{name}-r%{version}.jar > %{buildroot}%{_javadir}/%{name}-r%{version}.jar > > (cd %{buildroot}%{_javadir} && for jar in *-%{version}*; \ > do ln -sf ${jar} `echo $jar| sed "s|-%{version}||g"`; done) > > Needs to be modified to suit name of the jar file. The for cycle and sed call > are not used properly because there is "r" in the jar name before version. > Other than that package looks OK. Fix this one issue and I can approve it. Fixed. Please review again, thanks. Spec URL: http://huwang.fedorapeople.org/packages/guava/guava.spec SRPM URL: http://huwang.fedorapeople.org/packages/guava/guava-05-3.src.rpm Scratch built in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2257019 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review