[Bug 603295] Review Request: guava - Guava (Google Common Libraries)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603295

--- Comment #5 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-06-18 05:03:08 EDT ---
Unfortunately that symlink  in /usr/share/java is still wrong. This whole part:
install -Dpm 644 build/dist/guava-r%{version}/%{name}-r%{version}.jar  
%{buildroot}%{_javadir}/%{name}-r%{version}.jar

(cd %{buildroot}%{_javadir} && for jar in *-%{version}*; \
    do ln -sf ${jar} `echo $jar| sed "s|-%{version}||g"`; done)

Needs to be modified to suit name of the jar file. The for cycle and sed call
are not used properly because there is "r" in the jar name before version.
Other than that package looks OK. Fix this one issue and I can approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]