Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564518 --- Comment #2 from Ian Weller <ian@xxxxxxxxxxxxx> 2010-06-15 12:24:43 EDT --- It should be noted that the previous review is an unofficial review as part of Nathaniel's sponsorship process. Here are some comments for him as well as the packager. (In reply to comment #1) > [ FAIL ] BuildRequires are proper. > One dep per line is preferred. This really doesn't matter. > [ FAIL ] rpmlint is silent. > monodevelop-python.src:50: E: files-attr-not-set > monodevelop-python.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 4, > tab: line 10) > monodevelop-python.x86_64: E: no-binary > monodevelop-python.x86_64: W: only-non-binary-in-usr-lib > monodevelop-python.x86_64: W: no-documentation > monodevelop-python-devel.x86_64: W: no-documentation > > Put %defattr(-,root,root,-) under %files devel > Include LICENSE in both packages > Fix whitespace > > "E: no-binary" can probably be ignored. This usually means that the package should be marked as noarch. Unless there's a fairly good reason that's not the case... > [ FAIL ] owns the directories it creates. > You should probably do: > %dir %{_libdir}/monodevelop/AddIns/PyBinding If you drop %dir it'll own everything recursively, so you can drop the contents of that folder as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review