Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597597 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-06-14 11:53:56 EDT --- Hi Lars, here are a couple of initial things that need to be fixed: - remove the last sentence from the %description, as you're creating a binary package for Linux (so other OSes don't matter here) - Normally, you should call make with %{?_smp_mflags}. If the package doesn't build with it, remove it and add a comment about the issue. - .la files must not be packaged (remove them in %install and drop the corresponding line in %files) - add at least one newline between the various sections (here: %post, %postun, %files, %changelog, ...) to increase legibility - replace /usr/share/liblouis/* with %{_datadir}/liblouis/ and drop the %dir line - Always try to be specific when adding something in %files in order to avoid packaging unwanted files or directories. Thus, replace %{_includedir}/* with %{_includedir}/liblouis/ - for the same reason, replace %{_mandir}/man1/* with %{_mandir}/man1/lou_*.1* - replace %{_infodir}/liblouis.info.gz with %{_infodir}/liblouis.info* because the spec file shouldn't rely on a specific, automatically applied compression format (which could change in future rpm releases) - add file COPYING.LIB as %doc of the base package - The base package should only contain the library and its data files, since it's licensed under LGPLv3+. The command-line tools in %{_bindir} are licensed under GPLv3+, so they should go in a separate -tools subpackage together with file COPYING and the man1 manual pages. - drop .f12 from the %changelog entry That's all for now. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review