Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599097 --- Comment #17 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-06-14 11:55:01 EDT --- (In reply to comment #16) hey, Thank you for reviewing this :) > Here's the formal review. The package looks almost fine to me, except one > remaining aspect: > - replace %{_includedir}/gexiv2/* with %{_includedir}/gexiv2/ > to make the package own the directory too (and not only the header files) > ...... > ....... > [X] MUST: A package must own all directories that it creates. > - directory %{_includedir}/gexiv2/ must be owned by the -devel package > Fixed it. new srpm : http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2-0.0.91-2.fc13.src.rpm new spec http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2.spec rest of mock logs at http://ankursinha.fedorapeople.org/libgexiv2/ regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review