Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578480 --- Comment #22 from Matej Cepl <mcepl@xxxxxxxxxx> 2010-06-07 18:32:32 EDT --- (In reply to comment #20) > My point was that sprinkling the spec file with weird conditionals is not the > only way to have the package working in RHEL-5. Sometimes it makes sense to > have different but clean spec files in the branches. Both approaches are > acceptable in general. I think so, I don't see any obvious packaging error in my approach. Agree? > Do you intend to support EL-4 too? If not, then it's pretty much equivalent to: > %if 0%{?el5} Except that didn't work for me on RHEL-5. And no, I have zero interest in EL-4 > Fair enough. But I wonder if this part of the Guidelines applies then: > http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures Yes, except I have hard time to find the good failed build. It doesn't build for me on F-12 (https://koji.fedoraproject.org/koji/taskinfo?taskID=2236823), and there are too many missing packages on RHEL-5/PPC. > I see this is a pre-release snapshot. Let's compare the Release to the example > in the Guidelines: "kismet-0-0.1.20040110svn" > This suggests that you should rather use: > Release: 0.1.git20100526%{?dist} fixed > A comment is needed to describe how to recreate the tarball from git. fixed > > %build > > cmake -DCMAKE_INSTALL_PREFIX=%{_prefix} -DCMAKE_BUILD_TYPE=debug . > > make > > I know next to nothing about using cmake, but there are some cmake guidelines > (http://fedoraproject.org/wiki/Packaging/cmake) and they recommend something > else: > %build > %cmake . > make VERBOSE=1 %{?_smp_mflags} > Please either use the recommended form, or add a comment explaining why you use > something else. fixed, except that now build fails on my local virtual RHEL-5 machine ... http://fpaste.org/mkwv/ ... will investigate with the upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review