[Bug 537983] Review Request: python-visual - 3D Programming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537983

--- Comment #24 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-05-26 10:41:32 EDT ---
(In reply to comment #23)
> I'm still following this challenging review ^^.

Good to read :)

> Maybe you should not use the %exclude tag in %files, files tagges with it are
> included into the calculated size whereas they are not installed.
> 
> About the arch-ed doc package, I'm quite disappointed. If the examples, as
> supposed by their name, are not required to run visual, they should be
> considered to be documentation also, and set as %doc too.    


The reason, why I used %exclude was that, this is the easiest way to include
the examples into the doc package, without to differ from upstream.

Now I simply delete the examples and docs completely and include them as %doc
in the doc package.

This way it's slightly different from upstream, but the doc package is noarch
again and %exclude is gone now:

Spec URL: http://tomspur.fedorapeople.org/review/python-visual.spec
SRPM URL:
http://tomspur.fedorapeople.org/review/python-visual-5.32-5.fc13.src.rpm

Hope that is better this way... :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]