Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596074 --- Comment #5 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2010-05-26 11:26:31 EDT --- * Why don't you use upstream tarball http://multithreadedtc.googlecode.com/files/MultithreadedTC-1.01-source.zip ? Please use it. Note that you'll have to remove the jars from it. * You're missing Requires: jpackage-utils Requires(post): jpackage-utils Requires(postun): jpackage-utils They are needed because you invoke update_maven_depmap * You're missing Requires: jpackage-utils for the javadoc subpackage * Please remove ls -lR from install section * Please fix the following rpmlint warnings: multithreadedtc.noarch: E: description-line-too-long C It features a metronome that is used to provide fine control over the sequence of activities in multiple threads. Fix line length multithreadedtc.noarch: W: no-documentation You should include LICENSE.txt and README.txt as %doc multithreadedtc-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/multithreadedtc-1.0.1/package-list multithreadedtc-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/javadoc/multithreadedtc-1.0.1/stylesheet.css You should fix these by doing sed -i 's/\r//' <file_to_strip> for both of them in the %prep section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review