Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591222 Bastien Nocera <bnocera@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #11 from Bastien Nocera <bnocera@xxxxxxxxxx> 2010-05-21 13:04:42 EDT --- $ rpmlint /home/hadess/Projects/packages/SRPMS/gtk3-2.90.0-4.fc13.src.rpm gtk3.src: W: spelling-error %description -l en_US multi -> mulch, mufti gtk3.src: W: strange-permission update-gdk-pixbuf-loaders-3.0 0755L gtk3.src: W: strange-permission update-gtk-immodules-3.0 0755L gtk3.src:286: W: macro-in-comment %{_mandir} gtk3.src:287: W: macro-in-comment %{_mandir} gtk3.src:288: W: macro-in-comment %{_mandir} gtk3.src:325: W: macro-in-comment %{_mandir} gtk3.src:326: W: macro-in-comment %{_mandir} gtk3.src: W: no-cleaning-of-buildroot %clean gtk3.src: W: no-buildroot-tag gtk3.src: W: no-%clean-section gtk3.src:123: W: mixed-use-of-spaces-and-tabs (spaces: line 123, tab: line 123) 1 packages and 0 specfiles checked; 0 errors, 12 warnings. Apart from the tabs/spaces mix, this is all fine. $ rpmlint gtk3*rpm gtk3.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti gtk3.x86_64: W: incoherent-version-in-changelog 2.9.0.0-4 ['2.90.0-4.fc14', '2.90.0-4'] gtk3.x86_64: W: shared-lib-calls-exit /usr/lib64/libgdk-x11-3.0.so.0.9000.0 exit@xxxxxxxxxxx gtk3.x86_64: W: shared-lib-calls-exit /usr/lib64/libgdk_pixbuf_xlib-3.0.so.0.9000.0 exit@xxxxxxxxxxx gtk3.x86_64: W: shared-lib-calls-exit /usr/lib64/libgtk-x11-3.0.so.0.9000.0 exit@xxxxxxxxxxx gtk3.x86_64: W: no-manual-page-for-binary gtk-query-immodules-3.0-64 gtk3.x86_64: W: no-manual-page-for-binary update-gtk-immodules-3.0 gtk3.x86_64: W: no-manual-page-for-binary gtk-update-icon-cache-3.0 gtk3.x86_64: W: no-manual-page-for-binary update-gdk-pixbuf-loaders-3.0 gtk3.x86_64: W: no-manual-page-for-binary gdk-pixbuf-query-loaders-3.0-64 gtk3-devel.x86_64: W: spelling-error %description -l en_US amd -> mad, and, am gtk3-devel.x86_64: W: no-documentation gtk3-devel.x86_64: W: no-manual-page-for-binary gdk-pixbuf-csource-3.0 gtk3-devel.x86_64: W: no-manual-page-for-binary gtk3-demo gtk3-devel.x86_64: W: no-manual-page-for-binary gtk-builder-convert-3.0 gtk3-devel-docs.x86_64: W: file-not-utf8 /usr/share/doc/gtk3-devel-docs-2.90.0/examples/calendar/calendar.c gtk3-immodules.x86_64: W: spelling-error %description -l en_US gtk -> gt, gt k, GTE gtk3-immodules.x86_64: W: non-coherent-filename getfile?taskID=2201277&name=gtk3-immodules-2.90.0-4.fc14.x86_64.rpm gtk3-immodules-2.90.0-4.fc14.x86_64.rpm gtk3-immodules.x86_64: W: no-documentation gtk3-immodules.x86_64: W: non-conffile-in-etc /etc/X11/xinit/xinput.d/im-cedilla.conf gtk3-immodule-xim.x86_64: W: spelling-error %description -l en_US gtk -> gt, gt k, GTE gtk3-immodule-xim.x86_64: W: no-documentation The typo is real, and calendar.c should be fixed as well (probably upstream). package name: ok spec file name: ok packaging guidelines: see above license: ok license field: ok license file: ok spec file language: ok spec file legibility: ok Do this upstream? # fight unused direct deps sed -i -e 's/ -shared / -Wl,-O1,--as-needed\0/g' libtool # truncate NEWS awk '/^Overview of Changes/ { seen+=1 } { if (seen < 2) print } { if (seen == 2) { print "For older news, see http://git.gnome.org/cgit/gtk+/plain/NEWS";; exit } }' NEWS > tmp; mv tmp NEWS # # Make cleaned-up versions of tutorials, examples, and faq for installation # mkdir -p tmpdocs cp -aR docs/tutorial/html tmpdocs/tutorial cp -aR docs/faq/html tmpdocs/faq for dir in examples/* ; do if [ -d $dir ] ; then mkdir -p tmpdocs/$dir for file in $dir/* ; do install -m 0644 $file tmpdocs/$dir done fi done Use "install -D" # Input method frameworks want this mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/X11/xinit/xinput.d cp %{SOURCE3} $RPM_BUILD_ROOT%{_sysconfdir}/X11/xinit/xinput.d upstream sources: nak buildable: yes, runs fine in scratch excludearch: n/a build deps: ok locale handling: ok ldconfig: ok relocatable: n/a directory ownership: ok duplicate files: ok file permissions: ok %clean: ok content: permissible documentation: ok headers: ok static libs: ok pkgconfig files: ok shared libraries: ok devel package: ok libtool archives: ok gui apps: n/a file ownership: ok %install: ok utf8 filenames: ok Looks fine apart from the items mentioned above, and some upstream TODO items mentioned in the spec file. Feel free to ask for CVS when those items are fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review