Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473184 --- Comment #23 from Jonathan Dieter <jdieter@xxxxxxxxx> 2010-05-21 12:56:38 EDT --- Legend: X = Good - = Not so good N/A = Not applicable [ X ] MUST: rpmlint must be run on every package clamz.src: W: spelling-error %description -l en_US com's -> con's, om's, come's 1 packages and 0 specfiles checked; 0 errors, 1 warnings. clamz.x86_64: W: spelling-error %description -l en_US com's -> con's, om's, come's 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint doesn't like the com in Amazon.com. Maybe they'll change their name to make rpmlink happy. Or not. :) [ X ] MUST: The package must be named according to the Package Naming Guidelines [ X ] MUST: The spec file name must match the base package %{name} [...] [ ] MUST: The package must meet the Packaging Guidelines [ X ] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines [ X ] MUST: The License field in the package spec file must match the actual license [ X ] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc [ X ] MUST: The spec file must be written in American English. [ X ] MUST: The spec file for the package MUST be legible. [ X ] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. (sha256sum) ecc09d09ad329f2e24c9381983a56de3c944e3a933183ca342d25d5917f34968 clamz-0.4.tar.gz [ X ] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture (x86_64) [N/A] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [ X ] MUST: All build dependencies must be listed in BuildRequires [N/A] MUST: The spec file MUST handle locales properly. [N/A] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [N/A] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [ - ] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. $ rpm -qf /usr/share/mime/packages shared-mime-info-0.71-1.fc13.x86_64 It seems that according to the Guidelines, we need to add Require: shared-mime-info [ X ] MUST: A package must not contain any duplicate files in the %files listing. [ X ] MUST: Permissions on files must be set properly. [ X ] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} [ X ] MUST: Each package must consistently use macros. [ X ] MUST: The package must contain code, or permissable content. [N/A] MUST: Large documentation files must go in a -doc subpackage. [ X ] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [N/A] MUST: Header files must be in a -devel package. [N/A] MUST: Static libraries must be in a -static package. [N/A] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' [N/A] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [N/A] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [N/A] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [ X ] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [ X ] MUST: Packages must not own files or directories already owned by other packages. [ X ] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} [ X ] MUST: All filenames in rpm packages must be valid UTF-8. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review