Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593839 David Cantrell <dcantrell@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: urwid - |Review Request: |Console user interface |python-urwid - Console user |library |interface library --- Comment #8 from David Cantrell <dcantrell@xxxxxxxxxx> 2010-05-20 21:32:29 EDT --- (In reply to comment #7) > REVIEW: > > Legend: + = PASSED, - = FAILED, 0 = Not Applicable > > First, I would like to point out that package cannot be built on F-11/12 (and > EPEL 4/5) due to missing %{python_sitearch} definition on these platforms. So > you should keep this in mind while requesting cvs branches. Added those macros in. > Also, I after the Chen Lei would like to see this package renamed to > python-urwid. You may add additional "Provides: urwid = %{version}-%{release}" > also. Renamed the package to python-urwid. I did not add the Provides for urwid since this is the first time the package is being added. > - rpmlint is NOT silent: > > Sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/urwid-* > urwid.ppc: W: spelling-error %description -l en_US resizing -> residing, re > sizing, re-sizing > urwid.ppc: W: spelling-error %description -l en_US encodings -> encoding, > encoding s, encodes > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/container.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/listbox.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/escape.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/split_repr.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/signals.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/util.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/command_map.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/display_common.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/monitored_list.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/__init__.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/old_str_util.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/canvas.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/main_loop.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/curses_display.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/font.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/text_layout.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/html_fragment.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/raw_display.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/graphics.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/web_display.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/wimp.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/widget.py 0644 /usr/bin/python > urwid.ppc: E: non-executable-script > /usr/lib/python2.6/site-packages/urwid/decoration.py 0644 /usr/bin/python > 2 packages and 0 specfiles checked; 23 errors, 2 warnings. > Sulaco ~/rpmbuild/SPECS: > > This line can help suppressing most of these messages > > find urwid -type f -name "*.py" -exec sed -i '/^#!\/usr\/bin\/python/d' {} \; > > and this one - fixes permissions: > find urwid -type f -name "*.py" -exec chmod 644 {} \; Added these two find lines to %prep. > However I'm not aware of initial intention - it seems that many of these *.py > sources may be used as simple scripts while testing (just grep for __main__ and > see the results). We still don't use %check rpm target very often, so I'm > leaving this up to David to decide what to do with these files and rpmlint > errors. There is a test_urwid.py script at the top level which performs unit tests on the module. I added a %check section that runs this script. I left the other _test functions and classes in the module code. New spec file and SRPM uploaded: http://dcantrel.fedorapeople.org/python-urwid/python-urwid.spec http://dcantrel.fedorapeople.org/python-urwid/python-urwid-0.9.9.1-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review