Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #4 from David Cantrell <dcantrell@xxxxxxxxxx> 2010-05-20 21:03:48 EDT --- (In reply to comment #3) > I believe you should add the python macro to the spec file if you intend to > build for F12. > > https://fedoraproject.org/wiki/Packaging/Python#Macros Done. I don't plan on building wicd for anything below rawhide right now unless people ask for it, but I figure it doesn't hurt to include these macros in the spec file so people can grab the SRPM and rebuild on their own. I'd just like to get the package in to the distribution now and once we cut F-14 and beyond, we can start including wicd. > You don't need the CFLAGS="%{optflags}" as you aren't compiling anything > > CFLAGS="%{optflags}" %{__python} setup.py configure \ > --pmutils %{_libdir}/pm-utils/sleep.d > CFLAGS="%{optflags}" %{__python} setup.py build Removed. > Also the srpm doesn't build on F13 > > Checking for unpackaged file(s): /usr/lib/rpm/check-files > /home/leigh/rpmbuild/BUILDROOT/wicd-1.7.0-1.fc13.x86_64 > error: Installed (but unpackaged) file(s) found: > /usr/share/autostart/wicd-tray.desktop > > > RPM build errors: > user dcantrel does not exist - using root > group dcantrel does not exist - using root > user dcantrel does not exist - using root > group dcantrel does not exist - using root > user dcantrel does not exist - using root > group dcantrel does not exist - using root > File listed twice: /usr/lib/python2.6/site-packages/wicd > Installed (but unpackaged) file(s) found: > /usr/share/autostart/wicd-tray.desktop Strange. I rebuilt on my local F-13 box and it built fine. I also ran it through as a scratch dist-f13 build in koji: [fedora] dcantrel@mitre wicd$ koji build --scratch dist-f13 wicd-1.7.0-1.fc13.src.rpm Uploading srpm: wicd-1.7.0-1.fc13.src.rpm [====================================] 100% 00:00:06 406.66 KiB 61.06 KiB/sec Created task: 2200401 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2200401 None Watching tasks (this may be safely interrupted)... 2200401 build (dist-f13, wicd-1.7.0-1.fc13.src.rpm): free 2200401 build (dist-f13, wicd-1.7.0-1.fc13.src.rpm): free -> open (ppc06.phx2.fedoraproject.org) 2200403 buildArch (wicd-1.7.0-1.fc13.src.rpm, i686): free 2200402 buildArch (wicd-1.7.0-1.fc13.src.rpm, x86_64): free 2200402 buildArch (wicd-1.7.0-1.fc13.src.rpm, x86_64): free -> open (x86-07.phx2.fedoraproject.org) 2200403 buildArch (wicd-1.7.0-1.fc13.src.rpm, i686): free -> open (x86-03.phx2.fedoraproject.org) 2200402 buildArch (wicd-1.7.0-1.fc13.src.rpm, x86_64): open (x86-07.phx2.fedoraproject.org) -> closed 0 free 2 open 1 done 0 failed 2200403 buildArch (wicd-1.7.0-1.fc13.src.rpm, i686): open (x86-03.phx2.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 2200401 build (dist-f13, wicd-1.7.0-1.fc13.src.rpm): open (ppc06.phx2.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 2200401 build (dist-f13, wicd-1.7.0-1.fc13.src.rpm) completed successfully > This should be changed from > > %{python_sitelib}/wicd > > to > > %dir %{python_sitelib}/wicd > %{python_sitelib}/wicd/* The %dir line for this directory is already listed near the top of the %files list, but I did change the other line to %{python_sitelib}/wicd/* Thanks for the help! New spec file and SRPM posted: Spec URL: http://dcantrel.fedorapeople.org/wicd/wicd.spec SRPM URL: http://dcantrel.fedorapeople.org/wicd/wicd-1.7.0-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review