Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glade3 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177747 ------- Additional Comments From bugs.michael@xxxxxxx 2006-10-31 09:32 EST ------- > BuildRequires: perl(XML::Parser) The included intltool needs this. If intltool were not included, you would do "BuildRequires: intltool" instead. > --add-category X-Red-Hat-Base No. This is Extras, not Core. > rm -rf $RPM_BUILD_ROOT/var/scrollkeeper What's that? Unusual enough to add a comment in the spec file, please. > scrollkeeper-update -q || : > scrollkeeper-update -q -o %{_datadir}/omf/%{name} || : There are no such files in the package(s). > update-mime-database The package does not install such files which need this. * The package description refers to a "glade2" package and GTK+ 2.0, whereas this is glade3 for GTK+ >= 2.8. It is not spelled "GLADE" either. Upstream calls it "Glade". * Run "yum install glade2 glade3" and look at the desktop menus. They are almost identical and don't say which one is Glade3. As long as both shall coexist, I suggest you patch that. * %doc AUTHORS ChangeLog COPYING NEWS README TODO You have these duplicated in both packages. Including them in either one is more than enough, preferably "libgladeui" (or the main pkg if nothing is split off). * The build.log says: | checking for GTK... yes | checking for GNOME... configure: creating ./config.status | config.status: creating Makefile | Configuration: | | Source code location: . | Compiler: gcc | GnomeUI Catalog: no Adding "BuildRequires: libgnomeui-devel" changes that to "yes". If not wanted, use the --disable-gnome switch for reproducible builds. * glade3-devel is missing: Requires: gtk2-devel libxml2-devel > %package devel > Requires: %name = %{version} Ought to be full %{version}-%{release} > Requires: gail-devel Huh? No reference to libgail can be found. > Provides: glade-devel Splitting of libgladeui and libgladeui-devel instead of this sounds sane. You don't really want to occupy both the "glade3-devel" and "glade-devel" namespace. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review