Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593559 --- Comment #5 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-05-19 06:46:11 EDT --- I prefer you update release *and* changelog on every change. After all, that's what changelog is for. Patch to include TODO and ChangeLog a bit simpler: --- SPECS/protobuf-c.spec~ 2010-05-19 11:58:39.000000000 +0200 +++ SPECS/protobuf-c.spec 2010-05-19 12:39:41.447810201 +0200 @@ -41,8 +41,6 @@ %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT -install -p -m 644 -D TODO $RPM_BUILD_ROOT/%{_docdir}/TODO -install -p -m 644 -D ChangeLog $RPM_BUILD_ROOT/%{_docdir}/ChangeLog rm -f $RPM_BUILD_ROOT/%{_libdir}/libprotobuf-c.la %post -p /sbin/ldconfig @@ -55,8 +53,7 @@ %defattr(-,root,root,-) %{_bindir}/protoc-c %{_libdir}/libprotobuf-c.so.* -%doc %{_docdir}/TODO -%doc %{_docdir}/ChangeLog +%doc ChangeLog TODO %files devel %defattr(-,root,root,-) rpmlint warning: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 21) Seems like tags in -devel subpackage use tabs, remove those. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review