Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593559 --- Comment #4 from David Robinson <zxvdr.au@xxxxxxxxx> 2010-05-19 06:29:45 EDT --- - %{version} added (not sure how I missed that!) - %check now calls make check - added --disable-static option - removed .la file - added dep on protobuf-devel to devel subpackage - removed requires on protobuf... I didn't realise rpmbuild picked up dependencies like this. How do I know when requires is not explicitly needed? - added %doc's new package is here: http://koji.fedoraproject.org/koji/getfile?taskID=2196577&name=protobuf-c-0.13-1.fc14.src.rpm I haven't bumped %{release} - not sure whether I need to during review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review