Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583102 --- Comment #2 from Jean-Francois Saucier <jfsaucier@xxxxxxxxxxxx> 2010-05-07 10:16:26 EDT --- Spec URL: http://jfsaucier.fedorapeople.org/packages/radiotray.spec SRPM URL: http://jfsaucier.fedorapeople.org/packages/radiotray-0.5.1-2.fc12.src.rpm Thank you for your suggestions. rpmlint is still silent after the changes and build fine in mock. > ## The python_sitelib definition could be changed to Done, I did not notice this change since F-13, thanks for pointing this to me! > ## The build section could use > CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build Done. > ## line 37 could use %{__python} instead of python (optional) Done. > ## %{python_sitelib}/radiotray-0.5.1-py?.?.egg-info would help not break the > package in case of py version changes? Done. Thanks for pointing out some python stuff. I don't have many experience packaging python applications and with the new multiple python version feature in F-13, I think it's important to make these changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review