Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589867 Mohammed Imran <imranceh@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imranceh@xxxxxxxxx --- Comment #2 from Mohammed Imran <imranceh@xxxxxxxxx> 2010-05-07 10:00:55 EDT --- Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Rpmlint is silent [x] Package is not relocatable. [!] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) its not needed anymore, you can remove it [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPLv2 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package :86ea9f35183f28f95deb0aba509efb61 MD5SUM upstream package:86ea9f35183f28f95deb0aba509efb61 [x] Package is not known to require ExcludeArch, OR: [x] All build dependencies are listed in BuildRequires, except for any that [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [-] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [!] Permissions on files are set properly. retain %config(noreplace) lines,remove %attr(0755,root,root) lines,also group can be logcheck ? your makefile handles all this no need to list %dir %{_datadir}/logtail, just %{_datadir}/logtail/* is enough replace %{_sbindir}/logcheck %{_sbindir}/logtail %{_sbindir}/logtail2 with %{_sbindir}/* [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [!] Large documentation files are in a -doc subpackage, if required. make -doc package,also there is man page which you need to install in man directory [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. Needs to be Fixed ================== According to install instructins #-Extract logcheck and run make install. -Add an unpriviliged user for running logcheck. (typicallly named "logcheck") -chown -R logcheck /etc/logcheck /var/lock/logcheck /var/lib/logcheck -Be sure this user can access your log files -Edit logcheck configuration files in /etc/logcheck. Most importantly logcheck.conf. logcheck.logfiles contains a list of logfiles to be scanned. -Install logcheck cron job. There is a sample in debian/logcheck.cron.d where you are performing these steps ? you may use use scriptlets see http://fedoraproject.org/wiki/Packaging/ScriptletSnippets Please Fix the above issues please do read http://fedoraproject.org/wiki/Packaging/Guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review