Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589471 Yanko Kaneti <yaneti@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #2 from Yanko Kaneti <yaneti@xxxxxxxxxxx> 2010-05-07 06:37:04 EDT --- (In reply to comment #1) > Remove this, MODULE_COMPAT it's enough -> BuildRequires: perl >= 1:5.6.0 For this I've decided to stay with the Perl packaging guidelines for now. http://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires Once they are revised some automated tool would probably be used to remove that line for all modules. > Also do you need all requires? Don't they needed only as BuildRequires? It doesn't seem the perl autorequires work for usage declarations like the one that can be found in /usr/share/perl5/Test/POE/Server/TCP.pm use POE qw(Wheel::SocketFactory Wheel::ReadWrite Filter::Line); If not explicitly declared the built package ends without requirements for these. I've only removed the superfluous BuildRequires: perl(POE::Filter) > Change PERL_INSTALL_ROOT to DESTDIR, because this bug wasn't still removed from > cpanspec ;-) Done > None of these are blockers. Please fix it before upload. > > ACCEPTED Thanks! New Package CVS Request ======================= Package Name: perl-Test-POE-Server-TCP Short Description: POE Component providing TCP server services for test cases Owners: yaneti Branches: F-13 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review