Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-05-07 06:28:41 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2171526 + rpmlint is silent for SRPM and for RPM. kanjistrokeorders-fonts.src: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur, Kansas kanjistrokeorders-fonts.noarch: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur, Kansas 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + source files match upstream url (sha1sum) ba3a6a7904431c0969f196d2b2915ef6c87cff47 KanjiStrokeOrders_v2.014.zip there is no direct download url working using wget though. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Follow fonts packaging guidelines. Suggestions: 1) remove following comments from SPEC #ln -s /dev/null \ # %{buildroot}%{_fontconfig_confdir}/%{fontconf} 2) Give newline after each changelog entry and also between BuildRequires: line and %description line 3) Instead of adding BuildRequires: dos2unix, you can do following in %prep. ========================================================== for file in copyright.txt readme_en_v2.014.txt; do sed "s|\r||g" $file > $file.new && \ touch -r $file $file.new && \ mv $file.new $file done =========================================================== This will help not to increase build time dependency on dos2unix package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review