Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558849 Chen Lei <supercyper@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper@xxxxxxx --- Comment #2 from Chen Lei <supercyper@xxxxxxx> 2010-05-05 05:08:47 EDT --- Some minor problems: 1.Jni files are dlopend by jar files, so /sbin/ldconfig in %post and %postun is useless. 2.BuildRequires: gcc is not needed. 3. Use BuildRequires: java-devel >= 1:1.6.0 and Requires: java >= >= 1:1.6.0 instead of 1.5.0 4. mkdir -p $RPM_BUILD_ROOT is not needed. 5. examples should be installed into %{_docdir} install -d -m 755 ${RPM_BUILD_ROOT}%{_docdir}/%{name}-%{version}/examples cp *.py ${RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/examples -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review