Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558849 Guido Grazioli <guido.grazioli@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guido.grazioli@xxxxxxxxx --- Comment #1 from Guido Grazioli <guido.grazioli@xxxxxxxxx> 2010-04-07 14:05:33 EDT --- Hi i'd like to take up the review; some preliminar notes: * project name seems to be jepp (while Jep is the main class) * use %global instead of %define * pls fix indentation * group for -javadoc is "Documentation" * -javadoc pkg require jpackage-tools too * if you put DSO in %{_libdir}/%{name}, shouldnt you add that dir to ld.so.cond.d? * man page: use jep.1.* * use install -p to preserve timestamps -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review