[Bug 584966] Review Request: R-bitops - Functions for Bitwise operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=584966

Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #1 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2010-05-01 05:30:17 EDT ---
* source files match upstream:
   md5sum bitops_1.0-4.1.tar.gz 
81107518a0cafce266e82fc8571732da  bitops_1.0-4.1.tar.gz
   md5sum rpmbuild/SOURCES/bitops_1.0-4.1.tar.gz 
81107518a0cafce266e82fc8571732da  rpmbuild/SOURCES/bitops_1.0-4.1.tar.gz

* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in koji
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2142562).
* package installs properly
* rpmlint is silent.
  3 packages and 0 specfiles checked; 0 errors, 0 warnings.
* final provides and requires are sane
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Please update the changelog in a new release before importing the package in
the cvs.

** APPROVED **

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]