Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584974 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #5 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2010-05-01 05:28:50 EDT --- With the changes made, there is the review: * source files match upstream: md5sum combinat_0.0-7.tar.gz 61f163db2d314df276786631e2d6d966 combinat_0.0-7.tar.gz md5sum rpmbuild/SOURCES/combinat_0.0-7.tar.gz 61f163db2d314df276786631e2d6d966 rpmbuild/SOURCES/combinat_0.0-7.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in koji ( http://koji.fedoraproject.org/koji/taskinfo?taskID=2152940 ). * package installs properly * rpmlint produces 4 warnings, safe to ignore (spelling). 2 packages and 0 specfiles checked; 0 errors, 4 warnings. * final provides and requires are sane * %check is present and all tests pass. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. ** APPROVED ** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review