Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 --- Comment #15 from Milos Jakubicek <xjakub@xxxxxxxxxx> 2010-04-29 17:19:49 EDT --- (In reply to comment #14) > Ok, fresh review: > > [limb@paguroidea SPECS]$ rpmlint -i ../SRPMS/antlr-2.7.7-9.fc12.src.rpm > > The spelling errors are fine, but I'd like to see an explanation as to why the > tarball was modified and what steps were taken. Ideally, the comments should > contain exact instructions for deriving this tarball from upstream. I found out that the only differences was that the antlr.jar file was removed which is anyway assured by: find . -name "*.jar" -exec rm -f {} \; in %prep. => completely unnecessary, I removed that and uploaded the original tarball. > [limb@paguroidea SPECS]$ rpmlint -i ../RPMS/*/antlr* > > antlr-javadoc.noarch: W: dangerous-command-in-%post rm > antlr-javadoc.noarch: W: dangerous-command-in-%postun rm Both %post and %postun have been removed (a relict from jpackage %ghosting of javadoc). > antlr-manual.noarch: E: world-writable > /usr/share/doc/antlr-manual-2.7.7/Makefile 0666 > A file or directory in the package is installed with world writable > permissions, which is most likely a security issue. > > antlr-manual.noarch: W: spurious-executable-perm > /usr/share/doc/antlr-manual-2.7.7/Makefile.in > The file is installed with executable permissions, but was identified as one > that probably should not be executable. Verify if the executable bits are > desired, and remove if not. Both Makefile and Makefile.in removed, it didn't make any sense for them to be installed. > antlr-manual.noarch: W: spurious-executable-perm > /usr/share/doc/antlr-manual-2.7.7/csharp-runtime.html > The file is installed with executable permissions, but was identified as one > that probably should not be executable. Verify if the executable bits are > desired, and remove if not. Fixed. > antlr-tool.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/antlr-tool-2.7.7/LICENSE.txt > This file has wrong end-of-line encoding, usually caused by creation or > modification on a non-Unix system. It could prevent it from being displayed > correctly in some circumstances. Fixed. > If there is any documentation that could be put in the C++ subpackage, please > do so. What about the .hpp files? I assume there's a good reason they're not > in a -devel package, but it should be commented on in the spec. Yes, added. I also generated the doxygen documentation, but it's quite big so I put it into a -C++-docs package. I hope all the issues have been addressed, please check the current devel branch, thank you! Koji build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2146995 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review