Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583251 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-04-29 14:10:43 EDT --- ok rpmlint (just warnings which can be ignored) ok naming of package and spec ok spec file ok license approved and tag ok. Thanks spot! ok license in %doc ok correct language ok sha1sum on sources and ok url fb1c55f107a6af5ef8703a44d33476e508815913 dcfldd-1.3.4-1.tar.gz fb1c55f107a6af5ef8703a44d33476e508815913 dcfldd-1.3.4-1.tar.gz.spec ok koji build with correct buildreq ok excludearch - locale files - ldconfig ok no bundling ok owns, dirs and perms and only once ok macros ok code or content - large docs ok %doc not affect the runtime - headers|static in devel|static - .so in devel - devel dep on base - no .la|.a file - gui with desktop file ok own just not owned ok utf-8 file names ok separate file from upstream ok trans ok mock/koji see comment #8 ok testing - scriptlets sane - subpkgs dep on base - pkgconfig(.pc) in devel - req on package not on files ok add man pages The package dcfldd is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review