Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583949 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-04-29 14:06:01 EDT --- Well, - When the source says the license is "the same terms as Ruby", we use "GPLv2 or Ruby" as license tag. - BuildRoot is no longer needed on Fedora (although rpmlint may complain) - I don't think your mail address in the spec file is correct. - It is useful on Fedora CVS that you put one line between each %changelog entry like: --------------------------------------------------------------------- * Tue Apr 20 2010 Michal Fojtik <mfojtik@XXXXX> - 1.0.12-2 - Fixed permissions - Fixed timestamps * Tue Apr 20 2010 Michal Fojtik <mfojtik@XXXXX> - 1.0.12-1 - Initial package --------------------------------------------------------------------- Please fix the issue above when importing this package into Fedora. ------------------------------------------------------------- This pacakge (rubygem-xml-simple) is APPROVED by mtasaka ------------------------------------------------------------- Markus, thank you for pre-review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review