Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581220 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flag| |fedora-review? Bug 581220 depends on bug 582864, which changed state. Bug 582864 Summary: Review Request: qtlockedfile - QFile extension with advisory locking functions https://bugzilla.redhat.com/show_bug.cgi?id=582864 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA Resolution| |ERRATA Status|ON_QA |CLOSED --- Comment #6 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-04-28 11:01:33 EDT --- Looks good, comments follow: naming: good, though I'm curious why upstream tacks on _1 in the tarball name. ? sources: ok md5sum *.gz 902795eb13ecedbdc112f00d7ec22949 qtsingleapplication-2.6_1-opensource.tar.gz patches: please document patches (short .spec comment will suffice) , and preferably consult upstream about them. $ rpmlint *.rpm x86_64/*.rpm qtsingleapplication.src:52: W: configure-without-libdir-spec qtsingleapplication.x86_64: E: non-standard-executable-perm /usr/lib64/libQtSolutions_SingleApplication-2.6.so.1.0.0 0775L 4 packages and 0 specfiles checked; 1 errors, 1 warnings. I suppose using 'install -p -m755' instead of 'cp -a' can workaround this one, but you can choose whatever solution works best for you. license: ok scriptlets: ok macros: ok dependencies: ok %files: ok please address these comments, and I'll evaluate for final approval. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review