Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539948 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #8 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-04-28 10:59:18 EDT --- I can review this, naming: ok licensing: ok, though please confirm with upstream, sources contain GPLv2+ (or later) clause. runtime: ok, though I'd suggest adding a runtime dependency, %{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}} $ rpmlint *.rpm x86_64/*.rpm fqterm.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin fqterm.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes fqterm.src: W: invalid-url Source0: http://fqterm.googlecode.com/files/fqterm-0.9.6.3.tar.gz HTTP Error 404: Not Found fqterm.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo gin fqterm.x86_64: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/address.cfg.orig fqterm.x86_64: E: non-executable-script /usr/share/FQTerm/fqterm.sh 0644L /bin/sh fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/language.cfg.orig fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/fqterm.cfg.orig 3 packages and 0 specfiles checked; 4 errors, 5 warnings. These seem mostly harmless, though probably should omit the *.orig files from packaging. sources: ok $ md5sum *.gz d9415c20eb1df1be168a465025e41fbc fqterm-0.9.6.3.tar.gz .desktop file: ok, though I see you're using legacy/deprecated /usr/share/pixmaps for icon. I'd recommend using the newer, themeable /usr/share/icons instead. %build: please document why -DBUILD_SHARED_LIBS:BOOL=OFF is used. a short .spec comment is sufficient macros: ok scriptlets: ok please address items raised here, and we'll be close to approval. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review