[Bug 581334] Review Request: asl - Macro Assembler AS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581334

--- Comment #5 from Eric Smith <eric@xxxxxxxxxxxx> 2010-04-20 16:45:57 EDT ---
* License
The file doesn't appear to be used for anything.  I've reported the issue
upstream, and for now I have added an rm command in the %prep section.

* BuildRoot
I'd like to keep this for now, as I may also submit this for EPEL5.

* BR
Change made per your suggestion.

! using iconv
I can't do it in %prep, as the file is generated.  I'd rather do it in %build,
but unfortunately the upstream build system generates the doc files in "make
install", so without doing significant changes to the makefiles, it needs to
stay in %install.  If you think this is a serious problem, I'll talk with
upstream.

* %lang
Change made per your suggestion.

The updated spec and SRPM are:

Spec URL: http://fedorapeople.org/~brouhaha/asl/asl.spec
SRPM URL: http://fedorapeople.org/~brouhaha/asl/asl-1.42-0.3.bld77.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]