Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546686 --- Comment #3 from Arun SAG <sagarun@xxxxxxxxx> 2010-04-17 03:15:23 EDT --- Ankur, Thanks for the review. (In reply to comment #2) > quick review: > > - Please justify the explicit Requires > http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires > Yes, those requires are not needed, i removed them from spec file. http://koji.fedoraproject.org/koji/taskinfo?taskID=2122121 > - The src tar contains a Makefile, why not use use make install with required > directories as arguments instead of explicitly installing the files yourself? > > make install DESTDIR=%{buildroot} etc? Done. > > minor changes: > > summary could use an "A" : A cricket score applet for GNOME > > description could be changed to : "%{name} gets cricket scores to your panel", > instead of "The goal of.. " Done. SPEC URL: http://sagarun.fedorapeople.org/SPECS/cricscore-applet.spec SRPM URL: http://sagarun.fedorapeople.org/SRPMS/cricscore-applet-1.1.0.2-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review