Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546686 --- Comment #2 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-04-14 16:24:15 EDT --- quick review: - Please justify the explicit Requires http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires - The src tar contains a Makefile, why not use use make install with required directories as arguments instead of explicitly installing the files yourself? make install DESTDIR=%{buildroot} etc? minor changes: summary could use an "A" : A cricket score applet for GNOME description could be changed to : "%{name} gets cricket scores to your panel", instead of "The goal of.. " regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review