Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581161 --- Comment #4 from Dominic Hopf <dmaphy@xxxxxxxxxxxxxxxxx> 2010-04-10 19:25:41 EDT --- > Please don't use macros for trivial things like %{__install} or %{__rm}. This > has recently been discussed on the devel mailing list: > http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html Thanks for pointing this out Christoph. That saved me searching the source for my answer to Arun. ;) Arun, unfortunately I'm facing serious building problems with cowpatty. First, there is to say, rpmlint claims a debuginfo-without-sources error message on the debuginfo package. This basically is easily solved, by passing the optflags to configure - what the %configure macro actually already does. Since your upstream tarball doesn't provide a configure script at all, there is an alternate way to compile programs with the optflags, you can change your build command in the %build section to the following: make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" Unfortunately trying to build with that, that causes some openssl problems, even with having openssl-devel installed (Note you will first have to add missing BuildRequires for openssl-devel and libpcap-devel also). I will attach the concerning output here. Could you have a look at those and fix them - maybe in coorporation with upstream? I didn't finish the review yet, also because of the above mentioned compiler problems, but there are two more small things I noticed: * The INSTALL file doesn't need to be installed with the package, since there is no useful documentation for the user after he already installed the package. * There were some compiler warnings, but I guess upstream should already know about them -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review