Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xtide - Calculate tide all over the world https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211626 ------- Additional Comments From pertusus@xxxxxxx 2006-10-21 11:02 EST ------- Some more comments: * I noticed that in general you use pushd/popd, but at some places you use cd. * tideEditor needs to have a variable HFILE_PATH set (I guess for harmonic files localization?). So it certainly requires an /etc/profile.d file. it also certainly requires a .desktop and icon. * in libtcd install a $f crept in I agree with Michael about how links should be done using ldonfig -n * xttpd certainly would benefit from an init script. Regarding xttpd, could you please look at some basic security issues, like which user the daemon runs at. It would certainly make sense to put xttpd in another package, it is really a different beast from xtide. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review