Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575822 Neil Horman <nhorman@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(limb@xxxxxxxxxxxx | |) --- Comment #1 from Neil Horman <nhorman@xxxxxxxxxx> 2010-04-07 11:01:59 EDT --- rpmlint results [nhorman@hmsreliant Download]$ rpmlint ./bacula2-2.4.4-4.fc12.src.rpm bacula2.src: W: spelling-error Summary(en_US) bacula -> Dracula, backlash, oracular bacula2.src: W: spelling-error %description -l en_US Bacula -> Dracula, Backlash, Oracular bacula2.src: W: spelling-error %description -l en_US bacula -> Dracula, backlash, oracular 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Spelling errors are prettly clearly confusion on the part of rpmlint, so waive those. Naming: check. follows guidelines Spec File: Legible, american english, Good. Looks like you need tcp_wrappers-devel added as a BuildRequires also, it looks like you use the macro %{__initrddir} and I don't see where that is defined. Of course it builds fine, so I'm guessing I'm just missing something Initscript looks good The BuildRoot tag isn't needed anymore, but its ignored and correct if it were to be used, so don't worry about it License is ok (GPLv2 with exceptions), and included as %doc upstream sources match (4eb6155b45611018af03002d37a2ffde) Package Builds: check on x86_64 No DSO's in package, so we're good there No devel package No static libraries No double owned directories or files, check. install does a rm -rf %buildroot, check spec if utf-8, check builds in mock, check (after adding tcp_wrappers-devel to Buildrequires) subpackage client requires fully versioned common package, check I think if you fix the tcpwrappers issue (and explain the initrddir macro to me), I'll approve this, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review