[Bug 567094] Review Request: mumble - Voice chat suite aimed at gamers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567094

--- Comment #8 from Thomas Kowaliczek <linuxdonald@xxxxxxxxxxxxxx> 2010-03-28 10:25:16 EDT ---
MUST: rpmlint must be run on every package. The output should be posted in the
review.

[LinuxDonald@localhost x86_64]$ rpmlint *.rpm
mumble.x86_64: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers
mumble.x86_64: W: spelling-error %description -l en_US gamers -> gamer, games,
tamers
mumble-overlay.x86_64: W: spelling-error %description -l en_US gamers -> gamer,
games, tamers
mumble-overlay.x86_64: W: spelling-error %description -l en_US ingame -> in
game, in-game, Ingram
mumble-overlay.x86_64: W: no-documentation
mumble-overlay.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/mumble/libmumble.so
mumble-plugins.x86_64: W: spelling-error %description -l en_US gamers -> gamer,
games, tamers
mumble-plugins.x86_64: W: spelling-error %description -l en_US plugin -> plug
in, plug-in, plugging
mumble-plugins.x86_64: W: no-documentation
mumble-protocol.x86_64: W: spelling-error %description -l en_US gamers ->
gamer, games, tamers
mumble-protocol.x86_64: W: no-documentation
murmur.x86_64: W: spelling-error %description -l en_US gamers -> gamer, games,
tamers
murmur.x86_64: W: non-conffile-in-etc /etc/logrotate.d/murmur
murmur.x86_64: W: non-standard-uid /etc/rc.d/init.d/murmur mumble-server
murmur.x86_64: W: non-standard-gid /etc/rc.d/init.d/murmur mumble-server
murmur.x86_64: W: non-standard-uid /etc/murmur/murmur.ini mumble-server
murmur.x86_64: W: non-standard-gid /etc/murmur/murmur.ini mumble-server
murmur.x86_64: W: non-standard-uid /var/log/mumble-server mumble-server
murmur.x86_64: W: non-standard-gid /var/log/mumble-server mumble-server
murmur.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/murmur.conf
murmur.x86_64: W: non-standard-uid /etc/mumble-server.ini mumble-server
murmur.x86_64: W: non-standard-gid /etc/mumble-server.ini mumble-server
murmur.x86_64: W: non-standard-uid /var/run/mumble-server mumble-server
murmur.x86_64: W: non-standard-gid /var/run/mumble-server mumble-server
murmur.x86_64: W: non-standard-uid /usr/sbin/murmurd mumble-server
murmur.x86_64: W: non-standard-gid /usr/sbin/murmurd mumble-server
murmur.x86_64: W: non-standard-uid /var/lib/mumble-server mumble-server
murmur.x86_64: W: non-standard-gid /var/lib/mumble-server mumble-server
6 packages and 0 specfiles checked; 0 errors, 28 warnings.


MUST: The package must be named according to the  Package Naming Guidelines.
Okay

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
Okay

MUST: The package must meet the  Packaging Guidelines.
Okay

MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines.
Okay

MUST: The License field in the package spec file must match the actual license.
Okay

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
Okay

MUST: The spec file must be written in American English.
See in preview comment.

MUST: The spec file for the package MUST be legible.
Okay

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the  Source URL
Guidelines for how to deal with this.
Okay

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Okay

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Okay (it´s don´t needed here)

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
Okay

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OKay

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
Okay

MUST: Packages must NOT bundle copies of system libraries.
What abou celt and speex in the tarball?

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
Okay

MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
Okay

MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
Okay

MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
Okay

MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
Okay

MUST: Each package must consistently use macros.
Okay

MUST: The package must contain code, or permissable content.
Okay

MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
Okay

MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
Okay

MUST: Header files must be in a -devel package.
No devel package. Okay

MUST: Static libraries must be in a -static package.
Okay not needed.

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
What about libmumble.so in mumble-overlay package?
and the .so files in mumble-plugins?
Is that okay?

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}.
Okay (no devel package)

MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
Okay

MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
Okay (is that correct here: #install desktop file for mumble-overlay
#desktop-file-install --dir=%{buildroot}%{_datadir}/applications \
#%{SOURCE3}
@Packager

MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
Okay

MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
Okay

MUST: All filenames in rpm packages must be valid UTF-8.
Okay

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]