Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: <libtune> - <standard API to access the kernel tunables> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210007 ------- Additional Comments From konradr@xxxxxxxxxx 2006-10-19 12:07 EST ------- > The only thing I regret in removing the older releases is that having FC3 and > FC4 used to show how the library can be useful, with "exec-shield-randomize" > moving to "randomize_va_space" from FC3 to FC4 :-( <grin> > > 4). > > %{_libdir}/libtune.la > > %{_libdir}/libtune.so.0 > > %{_libdir}/libtune.so.0.0.0 > > > > you can glob them using the * > > > > Doing this I would get libtune.a and libtune.so too, while these 2 files have > to go in the -devel package. Am I wrong? > Before I address your question, I just realized that the version of the libtune libariries is 0.0.0. Should it be 0.10.1 ? The right globbing would be: %{_libdir}/*.so.* while for the devel: %{_libdir}/libtune.so %{_libdir}/libtune.a (which you have already) would work fine. > > 5). > > > > %post devel > > /sbin/chkconfig --add chtunedb > > /sbin/ldconfig > > > > You should have 'ldconfig' before running chkconfig. > > The service to be added (chtundb) doesn't use the library. > So I think that using that ordering or the one you propose is equivalent > (or may be I missed something?) > If it does not use the library, you are clear. > > 7). > > %preun devel > > /sbin/chkconfig --del chtunedb > > > > you probably should also check if the service is running (or just asssume it is > > ) before deleting it. > > > > /sbin/service chtunedb stop > /dev/null 2>&1 > > /sbin/chkconfig --del chtunedb > > > > Would do nicely. > > > > Actually, chtundb is run once at boot time: it just checks that the tunables > databases are coherent with the running kernel, then it leaves. That's why I > think there is no need to stop it before removing it. But if you think it > is better to do it the "standard way", I can fix this anyway. That is OK then. You can put a comment in the spec file saying that it is not needed since it is _not_ a daemon. > > 9) > > Run 'rpmlint' on your SRPM. Fix all of the errors. > > I used and old version of rpmlint that was silent... > Sorry! > > To be fixed > > 9). correction: rpmlint -v libtune-0.10-1.src.rpm I meant fixing all warnings and any errors if they are there ( I don't see errors, but there were a bit of warnings). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review