Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575376 --- Comment #2 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-03-20 13:14:38 EDT --- Looks good! Looks like there are optional tests depending on Authen::Simple -- this should be BR'ed. There's a sample script under examples/; why not include it in %doc? koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2065054 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 5d9c12b46f586f56dfd32e6b029cae6645e7621d CGI-Application-Plugin-Authentication-0.17.tar.gz 5d9c12b46f586f56dfd32e6b029cae6645e7621d CGI-Application-Plugin-Authentication-0.17.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-CGI-Application-Plugin-Authentication-0.17-1.fc13.noarch.rpm <===== ====> rpmlint perl-CGI-Application-Plugin-Authentication.noarch: W: spelling-error %description -l en_US authen -> authentic, author, Athens 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides for perl-CGI-Application-Plugin-Authentication-0.17-1.fc13.noarch.rpm perl(CGI::Application::Plugin::Authentication) = 0.17 perl-CGI-Application-Plugin-Authentication = 0.17-1.fc13 perl(CGI::Application::Plugin::Authentication::Driver) perl(CGI::Application::Plugin::Authentication::Driver::Authen::Simple) perl(CGI::Application::Plugin::Authentication::Driver::DBI) perl(CGI::Application::Plugin::Authentication::Driver::Dummy) perl(CGI::Application::Plugin::Authentication::Driver::Filter::crypt) perl(CGI::Application::Plugin::Authentication::Driver::Filter::lc) perl(CGI::Application::Plugin::Authentication::Driver::Filter::md5) perl(CGI::Application::Plugin::Authentication::Driver::Filter::sha1) perl(CGI::Application::Plugin::Authentication::Driver::Filter::strip) perl(CGI::Application::Plugin::Authentication::Driver::Filter::uc) perl(CGI::Application::Plugin::Authentication::Driver::Generic) perl(CGI::Application::Plugin::Authentication::Driver::HTPasswd) perl(CGI::Application::Plugin::Authentication::Store) perl(CGI::Application::Plugin::Authentication::Store::Cookie) perl(CGI::Application::Plugin::Authentication::Store::Session) ====> requires for perl-CGI-Application-Plugin-Authentication-0.17-1.fc13.noarch.rpm perl >= 0:5.006 perl(Apache::Htpasswd) perl(Attribute::Handlers) perl(base) perl(Carp) perl(CGI) perl(CGI::Cookie) perl(Class::ISA) perl(Digest::SHA1) perl(MIME::Base64) perl(:MODULE_COMPAT_5.10.1) perl(Scalar::Util) perl(strict) perl(UNIVERSAL::require) perl(warnings) =====> perl-CGI-Application-Plugin-Authentication-0.17-1.fc13.src.rpm <===== ====> rpmlint perl-CGI-Application-Plugin-Authentication.src: W: spelling-error %description -l en_US authen -> authentic, author, Athens 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides for perl-CGI-Application-Plugin-Authentication-0.17-1.fc13.src.rpm ====> requires for perl-CGI-Application-Plugin-Authentication-0.17-1.fc13.src.rpm perl perl(Apache::Htpasswd) perl(CGI::Application) perl(CGI::Application::Plugin::AutoRunmode) perl(CGI::Application::Plugin::Session) perl(CGI::Cookie) perl(Color::Calc) perl(Crypt::PasswdMD5) perl(DBD::SQLite) perl(Digest::SHA1) perl(Module::Build) perl(Task::Weaken) perl(Test::Exception) perl(Test::More) perl(Test::Pod) perl(Test::Warn) perl(UNIVERSAL::require) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review