Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: <libtune> - <standard API to access the kernel tunables> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210007 ------- Additional Comments From konradr@xxxxxxxxxx 2006-10-18 16:56 EST ------- 1). You are not using the Release tag everywhere. For example you do use it for building a tree, but you are not including it in the source. Source: %{name}-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Are you never going to increment the -release in the source code? If so, then it is OK to leave as is. 2). %description -n tunables-data-SLES9-2.6.5 This package supplies the tunables database for SuSE Linux Enterprise Server 9's 2.6.5 .... %description -n .. FC2/FC3/etc This package is for RHEL5/FC5,6. There is no need for these descriptions. Remove them and leave the one for FC5,6. 3). The spec file does not use %{optflags}, so nothing is compiled with the typical flags a Fedora build would use. For example - -j64 or optimizations. One way to do this is via export CFLAGS, as such: export CFLAGS="%optflags}" make %{?_smp_mpflags} 4). %{_libdir}/libtune.la %{_libdir}/libtune.so.0 %{_libdir}/libtune.so.0.0.0 you can glob them using the * 5). %post devel /sbin/chkconfig --add chtunedb /sbin/ldconfig You should have 'ldconfig' before running chkconfig. 6). %post /sbin/ldconfig -n %{_libdir} The -n %{_libdir} is not needed. 7). %preun devel /sbin/chkconfig --del chtunedb you probably should also check if the service is running (or just asssume it is ) before deleting it. /sbin/service chtunedb stop > /dev/null 2>&1 /sbin/chkconfig --del chtunedb Would do nicely. 8). you are using 'ldconfig' and 'chkconfig' programs. You should specify in the Requiere sections: Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig ... and so on. 9) Run 'rpmlint' on your SRPM. Fix all of the errors. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review