[Bug 210007] Review Request: <libtune> - <standard API to access the kernel tunables>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: <libtune> - <standard API to access the kernel tunables>


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210007





------- Additional Comments From Nadia.Derbey@xxxxxxxx  2006-10-16 08:15 EST -------
1st of all, thanks for taking some time to review this package!

Issue #1:
tundb_kernel and tundb_distro are symbolic links to the kernel / distro
databases that have actually been RPM installed. During the %build and %install
phases all the possible databases are built, and we still don't know which one
of them will actually be downloaded. That's why I postponed the symlink in the
post install. I'll look for a solution to this issue.

Issue #2:
Sure, it would be possible to generate the appropriate packages at RPM build
time. But you should have to build the package on a victim that has exactly the
same kernel release / distro as the target one. While with the current build
process, we use cross-compiling and we are completely independent of the system
we are building on.
But on the other hand, I like your proposal, since it could be a solution to
issue # 1!

Issue #3:
Do not agree: it's true that a dependency exists. But you should be allowed to
install tunables databases that do not necessarily match you current kernel /
distro. This is because you should be able to boot the same machine using
different kernel/distro releases:
if you are using, say an FC4 and want to reboot your machine in FC5, if you have
the databases for both releases, the reboot will be "transparent" from the
tunables databases point.
That's why I didn't use the Requires:
But if you think I'm wrong, only using the 1st 3 indices of the kernel release
should be enough (those are not changing too fast, are they?)

Issue #4:
To be fixed.
I must admit that I was not convinced that this was the best place for these
files. The only reason to put them there where to have all the files centralized
somewhere!

I'll update the bug as soon as I'm done with the fixes.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]