Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570424 --- Comment #4 from Satya Komaragiri <satya.komaragiri@xxxxxxxxx> 2010-03-10 03:48:41 EST --- > [!] %{buildroot} is removed at beginning of %install According to http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag, cleaning up of buildroot isn't required from Fedora 10 onwards. > [!] Package contains latest upstream version > * While checking the sha1sum I noted there were some changes on the code just > today, maybe you want to update the file and the release tag accordingly > then? Corrected. > [!] Package builds in mock > Tested on: F12/x86_64; see my note concerning README.md below > * The installation of the README.md is not okay yet. The file actually would > get installed in /, which obviuously is not the right place for documentation > files. --snip-- Corrected > * You should write down in your ChangeLog what you actually changed in the > package or rather in the specfile Corrected > * The release number should always begin with 0. --snip-- Corrected. The updated spec file may be found at: http://sundaram.fedorapeople.org/packages/transmission-remote-cli.spec And the updated SRPM is at: http://sundaram.fedorapeople.org/packages/transmission-remote-cli-0.5.5-0.3.20100310git.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review