Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509619 nucleo <alekcejk@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alekcejk@xxxxxxxxxxxxxx --- Comment #5 from nucleo <alekcejk@xxxxxxxxxxxxxx> 2010-03-05 13:22:47 EST --- Some comments about srtp.spec. 1. Versioned shared libraries libsrtp.so.0, libsrtp.so.0.0.0 should not be in -devel. They should be in main srtp package. See http://fedoraproject.org/wiki/Packaging/Guidelines#Devel_Packages 2. Main srtp package should contain description. But -devel and -static package can be with description like "Development files for %{name}." or "Static files for %{name}." I think that author name should not be in description because short description of package should be there. See http://fedoraproject.org/wiki/Packaging/Guidelines#Summary_and_description 3. Libtool archive libsrtp.la files, should not be included. See http://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries 4. I think that library version libsrtp.so.1 and libsrtp.so.1.0.0 (or may belibsrtp.so.1.4.4) will be more convenient. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review