Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565376 --- Comment #7 from Cheese Lee <cheeselee@xxxxxxx> 2010-03-05 13:06:29 EST --- * Followed all your instructions. * The default enabled plugins are just 'stardict' and 'web'. I removed explicit plugin claim in this revision. * Build successfully now on F-13: https://koji.fedoraproject.org/koji/taskinfo?taskID=2033580 Spec URL: http://dl.dropbox.com/u/612778/qstardict.spec SRPM URL: http://dl.dropbox.com/u/612778/qstardict-0.13.1-2.fc12.src.rpm (In reply to comment #6) > From next time please change the release number every time > you modify your spec file (unless version number changes) > > Some notes: > > * License > - License tag should be "GPLv2+" (the developer can change the > license freely even from GPLv3, if all the contributor for > the source codes agree it) > > * BuildRequires > - qt-devel is pulled in by kdelibs-devel, so explicitly writing > "BR: qt-devel" is not needed. > > - Also using vitrual dependency related BuildRequires is preferable > (i.e. "BR: kdelibs4-devel" is preferable) > > ? Enabled plugin > - Would you explain why you enable only "stardict web" plugins? > > * Macros > - Choose %{__make} or make, not use both. > > * %defattr > - Now we prefer to use %defattr(-,root,root,-) > > * Build failure > - Your srpm does not build on F-13: > http://koji.fedoraproject.org/koji/taskinfo?taskID=2018034 > This is because Fedora 13 changed the behavior of linker: > http://fedoraproject.org/wiki/UnderstandingDSOLinkChange > > To check F-13 linker behavior on F-12/11, you can do this by > 'make %{?_smp_mflags} LINK="g++ -Wl,--no-add-needed"' for > this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review