Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566406 --- Comment #4 from Nikolay Ulyanitsky <lystor@xxxxxxxxxxxxx> 2010-03-05 04:06:50 EST --- Thank you for starting the review. The license is changed to GPLv3 in 1.6.5 (COPYING file). The package is updated to 1.6.5 with all your suggestions. Spec diff: -%global prerelease dev - Name: packETH -Version: 1.6.4 -Release: 0.2.%{prerelease}%{?dist} +Version: 1.6.5 +Release: 1%{?dist} Summary: A GUI packet generator tool Group: Applications/Internet -License: GPLv2 +License: GPLv3 URL: http://sourceforge.net/projects/packeth/ -Source0: http://downloads.sourceforge.net/project/packeth/packETH-%{version}-%{prerelease}.tar.gz +Source0: http://downloads.sourceforge.net/project/packeth/packETH-%{version}.tar.bz Source1: packETH.desktop -# Use the pkg-config against invalid predefined CFLAGS, LIBS -# https://sourceforge.net/tracker/?func=detail&aid=2954084&group_id=87379&atid=582964 -Patch0: packETH-1.6.4-Makefile.patch -# Fedora-specific: Fix the pixmaps directory -Patch1: packETH-1.6.4-dev-pixmap_directory.patch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: desktop-file-utils BuildRequires: gtk2-devel -BuildRequires: glib2-devel %description -packETH is a linux GUI tool that is able to send any packet or sequence of -packets on the ethernet. It uses the RAW socket option, so it doesn't care +packETH is a Linux GUI tool that is able to send any packet or sequence of +packets on the Ethernet. It uses the RAW socket option, so it doesn't care about ip, routing, etc. It is designed to have all the options available, -with all the correct and incorrect values (incorect means, that user can +with all the correct and incorrect values (incorrect means, that user can send wrong parameters like: incorrect checksum, wrong header length, etc.). %prep -%setup -q -n %{name}-%{version}-%{prerelease} -%patch0 -p1 -b .Makefile -%patch1 -p1 -b .pixmap_directory +%setup -q %build -cd src -make %{?_smp_mflags} CFLAGS="%{optflags}" +%configure +%{__make} %{?_smp_mflags} %install %{__rm} -rf %{buildroot} -cd src -%{__mkdir} -p %{buildroot}/%{_bindir} -make install DESTDIR=%{buildroot} +%{__make} DESTDIR=%{buildroot} INSTALL='/usr/bin/install -p' install # Install desktop file %{__install} -d %{buildroot}%{_datadir}/applications @@ -60,13 +48,16 @@ %files %defattr(-,root,root,-) -%doc src/{COPYING,ChangeLog,README,TODO} +%doc AUTHORS COPYING README %{_bindir}/%{name} %{_datadir}/applications/%{name}.desktop -%{_datadir}/pixmaps/%{name} +%{_datadir}/packeth %changelog +* Fri Mar 05 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.6.5-1 +- Update to 1.6.5 + * Fri Feb 19 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.6.4-0.2.dev - Fix build error on F-13 with absent -lm in LIBS $ rpmlint packETH-1.6.5-1.fc13.i686.rpm packETH.i686: W: spelling-error %description -l en_US ip -> pi, up, op packETH.i686: W: spelling-error %description -l en_US checksum -> check sum, check-sum, checks um 1 packages and 0 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review