Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566406 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-03-04 14:12:32 EST --- Some notes: * License - License tag should be GPLv2+ * SourceURL ------------------------------------------------------------------ $ env LANG=C spectool -g packETH-1.6.4-0.2.dev.fc12.src/packETH.spec --2010-03-05 03:58:35-- http://downloads.sourceforge.net/project/packeth/packETH-1.6.4-dev.tar.gz Resolving downloads.sourceforge.net... 216.34.181.59 Connecting to downloads.sourceforge.net|216.34.181.59|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2010-03-05 03:58:36 ERROR 404: Not Found. ------------------------------------------------------------------ - The tarball in your srpm cannot be downloaded from the URL written in your spec file. Please follow https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net ! Note - Currently the newest seems 1.6.5 * BR - "BR: glib2-devel" is redundant because gtk2-devel Requires glib2-devel * Timestamp - Please consider to use ------------------------------------------------------------------ make install DESTDIR=%{buildroot} INSTALL="install -p" ------------------------------------------------------------------ to keep timestamps on installed files. This method usually works for Makefiles generated by recent autotools. * Consistent usage - If you want to use %{__rm} or %{__install}, also use %{__make} - Would you explain why you use both "%{__mkdir}" and "%{__install} -d" ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review