[Bug 562366] Review request: zinnia - online handwriting recognition system with machine learning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562366

--- Comment #13 from Chen Lei <supercyper@xxxxxxx> 2010-03-03 06:40:07 EST ---
Some additional comments :

1.perl-devel should not be used explicitly, use perl(ExtUtils::MakeMaker)
instead.

2..pyc files should be remove in prep section.


3.PERL_INSTALL_ROOT->
DESTDIR 
4.
If posslible, you should do %check section after %install especially for perl
wrapper

%check
#for C/C++ shared lib
LD_LIBRARY_PATH=%{buildroot}%{_libdir} make check
#for perl wrapper
pushd perl
make test
popd
for python wrapper
pushd python
%{__python} setup.py test

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]