Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562366 --- Comment #12 from Chen Lei <supercyper@xxxxxxx> 2010-03-03 04:26:21 EST --- (In reply to comment #11) > (In reply to comment #9) > > Some comments: > > 1. > > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > > distutils.sysconfig import get_python_lib; print get_python_lib()")} > > %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from > > distutils.sysconfig import get_python_lib; print get_python_lib(1)")} > > %define python 2.6 > > %ifarch x86_64 ppc64 > > %define python_sitelib /usr/lib64/python%{?python}/site-packages > > %endif > > -> > > %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) > > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > > distutils.sysconfig import get_python_lib; print(get_python_lib())")} > > %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from > > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} > > %endif > > > No, if python packages are built on 64bit and the packages are not noarch, > packages should define the python_sitelib again. If you do not do it, while > running %files section, rpmbuild will fail. For arch specfic package, python packages use python_sitearch, python_sitelib is desired for noarch package only. > > 2.Requires: python, db4 > > -> > Exactly they should be removed. > > Explicit requires is not needed > > 3.python-devel > > -> > > python2-devel > > > No, In Fedora, python 2.x series is still named as python and python-devel. > Python2 and python2-devel does not exit, although python3 will get into Fedora > 13. python2-devel is provided by python-devel rpm -q --whatprovides python2-devel For new python package guideline, we use python2-devel instead of python-devel > > 4.License: GPLv2+ > > -> > > not right, see Copying > I will correct it. > > 5.Url http://zinnia.sourceforget.net > > -> http://zinnia.sourceforge.net/ > Add a "/" seems to be unimportant. sourceforget are wrong! > > 6.%package utils > > Summary: Utils for the zinnia library > > Group: Development/Libraries > > -> group is not right, run "less /usr/share/doc/rpm-*/GROUPS" to see the > > complete list. > OK, i will follow it. > > 7.%package docs > > Summary: Documents for the zinnia library > > Group: Development/Libraries > > Requires: %{name} = %{version}-%{release} > > -> > > fedora recommend to use *-doc as the subpackage name, and Documentation as the > > value of the Group tag. > > Also -doc subpackage is noarch > In Fedora, many document packages are sitll named as *-docs. But I will rename > this package as zinnia-doc. > BuildArch: noarch should be added. > > 8. > > Choose %{__python} or python, not use both. > just for workable. Using a unified name should be better. > > 9.cp -pfr doc $RPM_BUILD_ROOT%{_docdir}/%{name} > > -> > > -doc subpackage should locate in %{name}-%{version}-doc or %{name}-{version} > > So "%doc doc" in the %file section of -doc subpackage is enough > > 10. > > %doc INSTALL > > %{_libdir}/lib%{name}.la > > INSTALL and *.la files should be removed after install > > 11. > > %files perl > > -> > > .packlist and empty *.bs files should be removed after install > I can not understand what you say about %files perl rpm -ql zinnia-perl, you'll find what I say. > > 12. > > %{python_sitelib} > > -> > > %{python_sitearch}/ For arch specfic packages, we must use python_sitearch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review